Skip to content

make check fails on Windows due to check-sanitycheck #25265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petrochenkov opened this issue May 10, 2015 · 3 comments · Fixed by #25266
Closed

make check fails on Windows due to check-sanitycheck #25265

petrochenkov opened this issue May 10, 2015 · 3 comments · Fixed by #25266

Comments

@petrochenkov
Copy link
Contributor

check-sanitycheck.py uses Unix-only module resource, make check runs check-sanitycheck and therefore fails on Windows

Traceback (most recent call last):
  File "C:/msys64/home/rust/src/etc/check-sanitycheck.py", line 16, in <module>
    import resource
ImportError: No module named resource

Workaround: use make tidy && make check-notidy instead of make check

cc @richo

@richo
Copy link
Contributor

richo commented May 10, 2015

Oof, sorry! Having a look now

@richo
Copy link
Contributor

richo commented May 10, 2015

What version of python and windows are you on? I was fairly sure that I confirmed this did something reasonable on not-posix, but I do not in fact have a windows box to test on. I'm kinda confused about how the builders are working right now.

@petrochenkov
Copy link
Contributor Author

msys2 x64 on Windows 7
Python 2.7.9

bors added a commit that referenced this issue May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants