Skip to content

FromStr::from_str method doc comment is inaccurate #25250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
frewsxcv opened this issue May 9, 2015 · 0 comments · Fixed by #25290
Closed

FromStr::from_str method doc comment is inaccurate #25250

frewsxcv opened this issue May 9, 2015 · 0 comments · Fixed by #25290

Comments

@frewsxcv
Copy link
Member

frewsxcv commented May 9, 2015

http://doc.rust-lang.org/1.0.0-beta.4/std/str/trait.FromStr.html#tymethod.from_str

Parses a string s to return an optional value of this type. If the string is ill-formatted, the None is returned.

This description is probably leftover from when from_str returned an Option
bluss pushed a commit to bluss/rust that referenced this issue May 10, 2015
docs: Update FromStr documentation
00f2157 
Fixes rust-lang#25250
@bluss bluss mentioned this issue May 10, 2015
Merged
bluss pushed a commit to bluss/rust that referenced this issue May 11, 2015
docs: Update FromStr documentation
4e8afd6 
Fixes rust-lang#25250
Manishearth added a commit to Manishearth/rust that referenced this issue May 11, 2015
@Manishearth
Rollup merge of rust-lang#25290 - bluss:docfixes, r=steveklabnik
bd764db 
Several Minor API / Reference Documentation Fixes

- Fix a few small errors in the reference.
- Fix paper cuts in the API docs.

Fixes rust-lang#24882
Fixes rust-lang#25233
Fixes rust-lang#25250
Manishearth added a commit to Manishearth/rust that referenced this issue May 11, 2015
@Manishearth
Rollup merge of rust-lang#25290 - bluss:docfixes, r=steveklabnik
f2c2736 
Several Minor API / Reference Documentation Fixes

- Fix a few small errors in the reference.
- Fix paper cuts in the API docs.

Fixes rust-lang#24882
Fixes rust-lang#25233
Fixes rust-lang#25250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Several Minor API / Reference Documentation Fixes bluss/rust
2 participants
@steveklabnik @frewsxcv