Skip to content

rustdoc doesn't parse cfgspecs properly #22131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apasel422 opened this issue Feb 10, 2015 · 0 comments · Fixed by #22135
Closed

rustdoc doesn't parse cfgspecs properly #22131

apasel422 opened this issue Feb 10, 2015 · 0 comments · Fixed by #22135
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@apasel422
Copy link
Contributor

It treats something like feature=bar as a single MetaWord instead of a MetaNameValue. This is due to the code on lines 70-73 of librustdoc/test.rs:

cfg.extend(cfgs.into_iter().map(|cfg_| {
    let cfg_ = token::intern_and_get_ident(&cfg_);
    P(dummy_spanned(ast::MetaWord(cfg_)))
}));

I have a PR for this that I will open shortly.

@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 10, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants