-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Change floating-point predicates to intrinsic calls if possible #1999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is no interop between C preprocessor definitions (such as macros) and anything in rust. |
Updated the title to reflect that. |
FIXME still present, think it's relevant. |
|
I spent a while looking for a Have we already dismissed operating directly on the bit-representation itself, the way that (my copy of) the |
Won't |
@huonw I cannot tell from your comment whether you looked at the implementations of That is what I think one needs a signbit intrinsic to access. (But then again, maybe what you are saying is that LLVM is much more aggressive than I expect and manages to turn |
I didn't check either the implementation or how aggressively LLVM optimises; it was a genuine question. (I guess that transmuting to a |
I don't know, that was what I was wondering when I asked about assuming IEEE 754. |
Low, not 1.0 |
The FIXME mentioned in the issue is no longer there as these have been reimplemented. If there is a specific performance issue demonstrated, we can file a new issue for it. |
is_positive
,is_negative
, and the like instd::f32
andstd::f64
. I tried, but couldn't figure out how to use a macro defined in a C math library header.is_normal
andfpclassify
mentioned in the FIXME at the end of the predicates instd::f32
.The text was updated successfully, but these errors were encountered: