Add extension impls for commonly used core functions and import by default #1968
Milestone
Comments
|
Done. |
celinval
pushed a commit
to celinval/rust-dev
that referenced
this issue
Jun 4, 2024
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this issue
Apr 22, 2025
This lint detects inefficient or useless `{std,core}::mem::swap()` calls
such as:
```rust
// Should be `a = temp();`
swap(&mut a, &mut temp());
// Should be `*b = temp();`
swap(b, &mut temp());
// Should be `temp1(); temp2();` if we want to keep the side effects
swap(&mut temp1(), &mut temp2());
```
It also takes care of using a form appropriate for a `()` context if
`swap()` is part of a larger expression (don't ask me why this wouldn't
happen, I have no idea), by suggesting `{ x = y; }` (statement in block)
or `{std,core}::mem::drop((temp1(), temp2())`.
changelog: [`swap_with_temporary`]: new lint
Close rust-lang#1968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We already have
vec.len(). There are a lot of other things that would be nice, particularly everything inoptionThe text was updated successfully, but these errors were encountered: