configure sometimes saves same key multiple times in config.mk with differing values
#17887
Comments
|
(The bug here is that we do a |
pnkfelix
added a commit
to pnkfelix/rust
that referenced
this issue
Oct 24, 2014
… `putvar`. Used aforementioned variants to extract options that have explicit `putvar` calls associated with them in the subsequent code. When the explicit `putvar` call was conditional on some potentially complex condition, moved the `putvar` call out to the main control flow of the script so that it always runs if necessary. ---- As a driveby fix, captured the error exit when doing the test run of `rustc --version` from `CFG_LOCAL_RUST_ROOT`, and signal explicit configure failure when it did not run successfully. (If we cannot run `rustc`, we really shouldn't try to keep going.) ---- Finally, in response to review feedback, went through and identified cases where we had been calling `putvar` manually (and thus my naive translation used `opt_nosave`/`valopt_nosave`), and then verified whether a manual `putvar` was necessary (i.e., was each variable in question manually computed somewhere in the `configure` script). In cases that did not meet this criteria, I revised the code to use the `opt`/`valopt` directly and removed the corresponding `putvar`, cleaning things up a teeny bit. ---- Fix rust-lang#17887.
bors
added a commit
that referenced
this issue
Oct 26, 2014
Fixes `config.mk` so that it should not contain multiple inconsistent entries for the same option. Used aforementioned variants to extract options that have explicit `putvar` calls associated with them in the subsequent code. When the explicit `putvar` call was conditional on some potentially complex condition, moved the `putvar` call out to the main control flow of the script so that it always runs if necessary. ---- As a driveby fix, captured the error exit when doing the test run of `rustc --version` from `CFG_LOCAL_RUST_ROOT`, and signal explicit configure failure when it did not run successfully. (If we cannot run `rustc`, we really shouldn't try to keep going.) ---- Fix #17887.
bors
added a commit
that referenced
this issue
Oct 27, 2014
Fixes `config.mk` so that it should not contain multiple inconsistent entries for the same option. Used aforementioned variants to extract options that have explicit `putvar` calls associated with them in the subsequent code. When the explicit `putvar` call was conditional on some potentially complex condition, moved the `putvar` call out to the main control flow of the script so that it always runs if necessary. ---- As a driveby fix, captured the error exit when doing the test run of `rustc --version` from `CFG_LOCAL_RUST_ROOT`, and signal explicit configure failure when it did not run successfully. (If we cannot run `rustc`, we really shouldn't try to keep going.) ---- Fix #17887.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don't mind our configure script, but it definitely has occasional warts.
For example, if I do:
% ../configure --enable-local-rust --local-rust-root=/nonexistantthen I get a
config.mkwith the following:Note that
CFG_LOCAL_RUST_ROOToccurs multiple times; I believe the semantics are that themakerun will pick up the last assigned value, but a reasonable human skimming the file is probably going to think that the first assignment is the only one in the file.The text was updated successfully, but these errors were encountered: