Skip to content

Remove time-boxed time inference regression mitigation note #129461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jieyouxu opened this issue Aug 23, 2024 · 2 comments · Fixed by #140839
Closed

Remove time-boxed time inference regression mitigation note #129461

jieyouxu opened this issue Aug 23, 2024 · 2 comments · Fixed by #140839
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Aug 23, 2024 •
edited
Loading

We should remove the time inference regression diagnostics note once sufficient time has passed.

Introduced in #129343 to help guide users to update their time version.

See #129343 (comment) for more context.

cc @apiraino as you wanted to make sure it gets removed eventually (thank you!)
@jieyouxu jieyouxu added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 23, 2024
@jieyouxu jieyouxu mentioned this issue Aug 23, 2024
Merged
@apiraino
Copy link
Contributor

Reminder for myself, Esteban set a timebomb ⏲️ for Rust 1.89, that should be enough to keep track of this (also see your comment).

@jieyouxu jieyouxu mentioned this issue Nov 20, 2024
Closed
@jieyouxu
Copy link
Member Author

(#133245 in case we forgor)

@jieyouxu jieyouxu mentioned this issue May 9, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue May 9, 2025
@bors
Auto merge of rust-lang#140839 - pietroalbini:pa-version-bump, r=piet…
9d891b4 
…roalbini

Bump version number to 1.89.0

Part of the release process. This PR must not be rolled up.

Closes rust-lang#129461.

r? `@ghost`
bors added a commit to rust-lang-ci/rust that referenced this issue May 9, 2025
@bors
Auto merge of rust-lang#140839 - pietroalbini:pa-version-bump, r=piet…
a9d24f2 
…roalbini

Bump version number to 1.89.0

Part of the release process. This PR must not be rolled up.

Closes rust-lang#129461.

r? `@ghost`
@bors bors closed this as completed in dcecb99 May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump version number to 1.89.0 pietroalbini/rust
Disarm time 💣 (diagnostics) jieyouxu/rust
2 participants
@apiraino @jieyouxu