Skip to content

Change all XXX's to FIXME's #11816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jan 26, 2014 · 1 comment
Closed

Change all XXX's to FIXME's #11816

brson opened this issue Jan 26, 2014 · 1 comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jan 26, 2014

After we stop requiring FIXME's to have issue numbers, all the XXX's that were written to get around that restriction can be converted to FIXME's.

cc #11815
@brson
Copy link
Contributor Author

brson commented Jan 26, 2014

Oh, hey. This is the exact same title as #3303. We can just repurpose that one.

@brson brson closed this as completed Jan 26, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 1, 2023
@bors
Auto merge of rust-lang#11817 - y21:ptr_arg_mut_ref, r=Alexendoo
003e910 
[`ptr_arg`]: recognize methods that also exist on slices

Fixes rust-lang#11816

Not a new lint, just a very small improvement to the existing `ptr_arg` lint which would have caught the linked issue.

The problem was that the lint checks if a `Vec`-specific method was called, that is, if the receiver is `Vec<_>`.
This is the case for `len` and `is_empty`, however these methods also exist on slices so we can still lint there.
This logic exists in a different lint, so we can just reuse that here.

Interestingly, there was even a comment up top that explained what it should have been doing, but the logic for it just wasn't there?

changelog: [`ptr_arg`]: recognize methods that also exist on slices

<sub>Also, this is my 100th PR to clippy 🎉 </sub>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson