Skip to content

Add State Of Rust triage procedure #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2018

Conversation

XAMPPRocky
Copy link
Member

@BatmanAoD
Copy link
Member

A few things to resolve:

  • Sometimes the active RFC is superseded without being closed; this is not always obvious without clicking through to the RFC, then to the tracking issue, then to links in the tracking issue, finally arriving at a new RFC and associated tracking issue.
    • It's probably worth explicitly mentioning in the procedure that the linked RFC may have been superseded.
    • Unfortunately, I'm not sure it's always clear which RFC is "active"...when there's confusion, should we just ask for feedback in the related RFC threads?
  • Should we have guidelines on what conditions warrant pinging the participants in the tracking-issue thread? For instance, if a tracking issue hasn't been updating in a few weeks, but you suspect (for some reason) that work may have been done without updating the issue, does that warrant a ping?

@XAMPPRocky
Copy link
Member Author

Yes, I meant to have an item about pinging, I just forgot it. I was thinking if there's been seemingly no activity for 21 days/3 weeks. I was wondering who should be pinged though? The creator of the tracking issue? The team responsible for the RFC?

@BatmanAoD
Copy link
Member

@Aaronepower I think it probably depends on the state of the issue. From most to least specific:

  • If someone has started implementing it: ping them; if they've been pinged already and haven't responded for a week (or two?), consider it an "orphaned" implementation
  • If no one has started implementing it, or if it's "orphaned": ping the relevant team for implementing (probably the compiler team for language features?)
  • If there's no clear choice for the team that should be doing the implementation, ping the team and/or individual(s) responsible for the RFC

@XAMPPRocky
Copy link
Member Author

@BatmanAoD I've added in those instructions, feel free to review!

@BatmanAoD
Copy link
Member

Looks good! I've submitted some minor edits as a PR against your fork's master branch.

Small stylistic & typo fixes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good with one additional note.

ping the relevant team.
* If there is no clear choice for the team that should be doing the
implementation, ping the team and/or individual(s) responsible for
the RFC.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think this should essentially never happen. Could we add a "please add this to release team meeting notes" so we can discuss what went wrong to let this happen? Ideally all RFCs are pretty much well placed to be implemented by a concrete team(s).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I cannot recall an instance where I made a tracking issue with no responsible team.

@Mark-Simulacrum
Copy link
Member

Okay, let's merge this! Thanks!

I think it might be worth talking to @Centril about this as well to possibly help integrate this into the normal RFC merge procedure, since they've been doing quite a bit of that lately :)

@Mark-Simulacrum Mark-Simulacrum merged commit 5ac6f2a into rust-lang:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants