RIIR update_lints: use WalkDir instead of read_dir #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fs::read_dir` does not recurse into subdirectories.
|
(I was super surprised that |
phansch
added
the
S-waiting-on-review
oli-obk
reviewed
Oct 15, 2018
| fs::read_dir("../clippy_lints/src") | ||
| .unwrap() | ||
| fn lint_files() -> impl Iterator<Item=walkdir::DirEntry> { | ||
| WalkDir::new("../clippy_lints/src") |
There was a problem hiding this comment.
can you add a comment here that we use WalkDir instead of fs::read_dir to recurse into the directories?
|
r=me with nit fixed |
phansch
added
S-blocked
|
going to hold off on merging due to hyperium/mime#93 |
|
@phansch |
phansch
removed
the
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to traverse into subdirectories in order to collect all lints.
read_dirdoesn't do that andWalkDirseems like the safest/quickest way to achieve that.cc #2882