WIP: update_lints.py RIIR #3266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
force-pushed
the
riir_update_lints_all
branch
from
9ae2d9e to
489bded
Compare
phansch
added
the
S-waiting-on-author
phansch
added a commit
to phansch/rust-clippy
that referenced
this pull request
Oct 11, 2018
Small refactoring pulled out of work on rust-lang#3266. This should make the methods a bit more flexible.
|
Going to close this in favor of smaller, more manageable PRs (which also helps my motivation ✊ ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that I had this branch laying around 🤦♂️
I'd say it's about 70% finished, and I hope to finish it next week.
Once this is done, the rust rewrite will work the same as
update_lints.py, with the added benefit of being unit tested and working on other platforms.cc #2882