Improve needless_as_bytes to also detect str::bytes()
#13972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are checking that we are calling the `as_bytes()` method of `String` or `str`. Checking that it returns a `slice()` does not add anything.
This builds upon the lint for `str::as_bytes()`, and also covers needless uses of the iterator version `str::bytes()`.
rustbot
added
the
S-waiting-on-review
|
Please run |
|
Sorry, took me a while to realize I had simply not pushed my branch! |
|
Happens to the best of us. Thank you! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran Clippy on some projects after upgrading to 1.84, which found a needless use of
as_bytes(). It made me notice that the code was also usingbytes()needlessly in other places. This PR improves on theas_bytes()lint to also lintbytes().changelog: none