Extend UNNECESSARY_TO_OWNED to handle split
#11871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? @llogiq |
llogiq
reviewed
Dec 16, 2023
| fn main() { | ||
| let _ = "a".to_string().split('a').next().unwrap(); | ||
| //~^ ERROR: unnecessary use of `to_string` | ||
| let _ = "a".to_owned().split('a').next().unwrap(); |
There was a problem hiding this comment.
I'd like to see a test splitting by a &str and perhaps a counter-test that calls split by () which is implemented by a custom trait (if that is even possible?).
There was a problem hiding this comment.
Implementing the Pattern trait is... quite a lot of code. So instead, I added checks for both char and str and also added the equivalent tests on slice.
GuillaumeGomez
force-pushed
the
UNNECESSARY_TO_OWNED-split
branch
3 times, most recently
from
efddb33 to
238c5f9
Compare
|
Updated! |
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9965.
When you have
to_string().split('a')or equivalent, it'll suggest to remove theto_owned/to_stringpart.r? @flip1995
changelog: Extend
UNNECESSARY_TO_OWNEDto handlesplit