Skip to content

Remove unnecessary clone from needless_collect example #10786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mickvangelderen
Copy link
Contributor

The example for clippy::needless_collect is written as follows:

let len = iterator.clone().collect::<Vec<_>>().len();
// should be
let len = iterator.count();

With this change, the unnecessary clone() is removed and the the standard

### Example
```rust
// original
```
Use instead:
```rust
// improved
```

structure is followed.

Discussion: #10784 (comment)

changelog: [needless_collect]: Cleaned up the example in the lint documentation.

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 15, 2023
@Alexendoo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented May 15, 2023

📌 Commit 79eb06c has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 18, 2023

⌛ Testing commit 79eb06c with merge 9cd483d...

@bors
Copy link
Contributor

bors commented May 18, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 9cd483d to master...

@bors bors merged commit 9cd483d into rust-lang:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants