Stack overflow fix #10081
Closed
Stack overflow fix #10081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#10041. Prevent recusion into Self when it's a generic parameter. Added regression test from example in rust-lang#10041.
|
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
This includes #10068 + the changes mentioned in #10068 (comment) which I have authored @nbdd0121 :) |
|
@bors try |
bors
added a commit
that referenced
this pull request
Dec 15, 2022
Stack overflow fix See #10068 (comment) for details -- original PR description of #10068 -- fixes #10041 Prevent recursion into Self when it's a generic parameter. Added regression test from example in #10041. - \[x] Followed [lint naming conventions][lint_naming] - **N/A** - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - **N/A** - \[x] Added lint documentation - **N/A** - \[x] Run `cargo dev fmt` changelog: [`new-ret-no-self`] Fix segmentation fault caused when generic parameter defaults to `Self` and is unspecified. For example, `fn uh_oh(&self)>
|
💔 Test failed - checks-action_test |
See rust-lang#10068 (comment) for details -- original PR description of rust-lang#10068 -- fixes rust-lang#10041 Prevent recursion into Self when it's a generic parameter. Added regression test from example in rust-lang#10041. - \[x] Followed [lint naming conventions][lint_naming] - **N/A** - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - **N/A** - \[x] Added lint documentation - **N/A** - \[x] Run `cargo dev fmt` changelog: [`new-ret-no-self`] Fix segmentation fault caused when generic parameter defaults to `Self` and is unspecified. For example, `fn uh_oh(&self) -> impl PartialOrd { ... }` has a hidden `Rhs=Self` as the generic parameter for `PartialOrd`.
matthiaskrgr
force-pushed
the
stack_overflow_fix
branch
from
eecec91 to
f613ad9
Compare
|
I only replaced half of the recursion, oops :D |
|
@bors try |
bors
added a commit
that referenced
this pull request
Dec 15, 2022
Stack overflow fix See #10068 (comment) for details -- original PR description of #10068 -- fixes #10041 Prevent recursion into Self when it's a generic parameter. Added regression test from example in #10041. - \[x] Followed [lint naming conventions][lint_naming] - **N/A** - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - **N/A** - \[x] Added lint documentation - **N/A** - \[x] Run `cargo dev fmt` changelog: [`new-ret-no-self`] Fix segmentation fault caused when generic parameter defaults to `Self` and is unspecified. For example, `fn uh_oh(&self)>
matthiaskrgr
commented
Dec 15, 2022
Comment on lines
+1
to
18
| error: methods called `new` usually return `Self` | ||
| --> $DIR/methods.rs:96:5 | ||
| | | ||
| LL | / async fn new() -> Option<Self> { | ||
| LL | | None | ||
| LL | | } | ||
| | |_____^ | ||
| | | ||
| = note: `-D clippy::new-ret-no-self` implied by `-D warnings` | ||
|
|
||
| error: methods called `new` usually return `Self` | ||
| --> $DIR/methods.rs:104:5 | ||
| | | ||
| LL | / fn new() -> i32 { | ||
| LL | | 0 | ||
| LL | | } | ||
| | |_____^ | ||
| | | ||
| = note: `-D clippy::new-ret-no-self` implied by `-D warnings` | ||
|
|
There was a problem hiding this comment.
do we need some extra code to avoid FPs here?
There was a problem hiding this comment.
So this looks like a fp to me but haven't figured out yet how to work around that
|
☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
matthiaskrgr
added
the
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10068 (comment) for details
-- original PR description of #10068 --
fixes #10041
Prevent recursion into Self when it's a generic parameter. Added regression test from example in #10041.
.stderrfile)cargo testpasses locallycargo dev update_lints- N/Acargo dev fmtchangelog: [
new-ret-no-self] Fix segmentation fault caused when generic parameter defaults toSelfand is unspecified. For example, `fn uh_oh(&self)>