Some function pointers, typedefs, and OSX's stdlib. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 tasks
Merged
nox
suggested changes
Sep 22, 2016
| if !declaration.is_valid() { | ||
| if let Some(location) = location { | ||
| if location.kind() == CXCursor_ClassTemplate || | ||
| location.kind() == CXCursor_ClassTemplatePartialSpecialization { |
There was a problem hiding this comment.
Yeah, I want to use the matches! crate instead, here and in a few other places, but I'll do that in a follow-up.
|
|
||
|
|
||
| extern "C" { | ||
| pub fn atexit_b(arg1: ::std::option::Option<unsafe extern "C" fn()>); |
There was a problem hiding this comment.
We should just bind blocks to *mut c_void given their ABI is weird.
Signed-off-by: Emilio Cobos Álvarez <[email protected]>
nox
suggested changes
Sep 22, 2016
| } | ||
| } | ||
| declaration = declaration.canonical(); | ||
| if !declaration.is_valid() { |
There was a problem hiding this comment.
Here you rebound declaration to the canonical one, which is invalid.
What does the debug! message end up saying, given the declaration you passed to it is the invalid one now?
nox
approved these changes
Sep 22, 2016
|
@bors-servo r+ |
|
📌 Commit cc8ed87 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Sep 22, 2016
Some function pointers, typedefs, and OSX's stdlib. r? @nox The change from indexing cursors to index USRs was because in the `inner_template_self` test, the `next` pointer pointed to a clang-generated class declaration that caused us to not catch the type as already resolved. Also, that's the recommended way to check against same symbols from different translation units, though now we don't use it yet.
bors-servo
pushed a commit
that referenced
this pull request
Sep 23, 2016
Union support Built on top of #58, this adds support for untagged unions if not running under the `--no-unstable-rust-flag`. The last commit is an example try run passing with this, but should be reverted (and the `--no-unstable-rust` flag passed by default to our harness). This depends on serde-deprecated/aster#109. r? @nox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nox
The change from indexing cursors to index USRs was because in the
inner_template_selftest, thenextpointer pointed to a clang-generated class declaration that caused us to not catch the type as already resolved.Also, that's the recommended way to check against same symbols from different translation units, though now we don't use it yet.