Forbid TODO markers on master branch #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tend to use TODO and FIXME exactly the other way around ;) |
|
yeah, me to, but rust-lang/rust prefers FIXME, and it makes sense to be consistent with it? |
|
The merge of #982 will have introduced another |
|
I don't plant to merge this until #988 is r+ed :) |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 23, 2019
990: Forbid TODO markers on master branch r=matklad a=matklad this makes TODO markers useful for things which you want to fix before sending a PR Co-authored-by: Aleksey Kladov <[email protected]>
|
A bit of git archeology revealed this: rust-lang/rust@fe77e96 Basically, there once was a policy in rust-lang to require issue numbers on FIXME comments, and to do was forbidden as a work-around for that. I guess it's a good idea to create issues for FIXMEs on a best-effort bases! |
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 23, 2019
990: Forbid TODO markers on master branch r=matklad a=matklad this makes TODO markers useful for things which you want to fix before sending a PR Co-authored-by: Aleksey Kladov <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes TODO markers useful for things which you want to fix before sending a PR