Hover: Show documentation #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Nov 6, 2018
| impl FileSymbol { | ||
| pub fn docs(&self, file: &File) -> Option<String> { | ||
| file.syntax().descendants() | ||
| .filter(|node| node.kind() == self.kind && node.range() == self.node_range) |
There was a problem hiding this comment.
Feels like we probably should move FileSymbols to ra_analysis, and use SyntaxPtr
There was a problem hiding this comment.
Sounds like a good idea. I can tackle that in a separate PR.
|
LGTM |
|
@matklad is this good to go? |
|
Ci's failing, otherwise LGTM! |
|
It looks like it failed on the format check so I rebased and ran |
The right command is |
|
bors r+ Thanks! |
bors bot
added a commit
that referenced
this pull request
Nov 7, 2018
196: Hover: Show documentation r=matklad a=kjeremy Closes #186 Co-authored-by: Jeremy A. Kolb <[email protected]>
Build failed |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 7, 2018
196: Hover: Show documentation r=matklad a=kjeremy Closes #186 Co-authored-by: Jeremy A. Kolb <[email protected]>
|
bors r+ |
|
Not awaiting review |
|
bors or travis are having a bad day it seems, merging manually. |
Timed out |
meliache
added a commit
to meliache/rust-analyzer
that referenced
this pull request
Jan 25, 2023
Emacs has now two LSP clients, the more minimalistic and lightweight Eglot and the extensive though a bit bloated LSP-Mode. Eglot will soon be shipped with Emacs29. Both have rust-analyzer enabled by default and require no further setup then just being installed and enabled. `lsp-rust.el` is not required anymore. The base-installation for each of those modes is so easy now that I don't think an enumerated list is necessary, both package can be installed via the standard `M-x package-install` and the installation is a one-liner that I provide. Configuration mostly comes into play for support the rust-analyzer extensions to the LSP protocol, which are built into LSP mode and require an extension-package for Eglot. But for the configuration beyond the base configuration I link against official documentation, quickstart guides and documentation for the lsp extensions, to avoid showing outdated information here. This commit is mostly a duplicate of a PR [1] that I made against the rust-analyzer github project. [1]: rust-analyzer/rust-analyzer.github.io#197, rust-analyzer/rust-analyzer.github.io@7ff0113 ma Resolves Issue rust-lang#196: rust-analyzer/rust-analyzer.github.io#196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186