increase AUTODEREF_RECURSION_LIMIT to 20
#19004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The limit was introduced in rust-lang#1408 (comment) to avoid infinite cycles but it effectively caps the number of derefs to 10. Types like `ID3D12Device14` from the `windows` crate run into this because it derefs to `ID3D12Device13`, 13 to 12 and so on. Increasing it to 20 is a quick fix; a better cycle detection method would be nicer long term.
rustbot
added
the
S-waiting-on-review
|
The compiler also doesn't detect cycles and instead has a limit, although the compiler's limit is configurable. |
|
Thanks! |
|
Hm, the compiler's limit seems to be 128 by default: https://github.com/rust-lang/rust/blob/dee7d0e730a3a3ed98c89dd33c4ac16edc82de8a/compiler/rustc_middle/src/middle/limits.rs#L39 20 is probably fine for now, if others run into this it can be increased further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limit was introduced in #1408 (comment) to avoid infinite cycles but it effectively caps the number of derefs to 10. Types like
ID3D12Device14from thewindowscrate run into this because it derefs toID3D12Device13, 13 to 12 and so on. Increasing it to 20 is a quick fix; a better cycle detection method would be nicer long term.