Skip to content

Fix incorrectly replacing references in macro invocation in "Convert to named struct" assist #15887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jinohkang-theori
Copy link
Contributor

@jinohkang-theori jinohkang-theori commented Nov 14, 2023

Fixes #15630.

Complements #13647 (same assist but missed this one), #14920 (inverse action assist).

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2023
@jinohkang-theori jinohkang-theori marked this pull request as draft November 14, 2023 06:54
@jinohkang-theori jinohkang-theori force-pushed the fix/ide-assists/convert_tuple_struct_to_named_struct/handle_refs_inside_macro_invocations branch from 78cb502 to 0beba7c Compare November 14, 2023 07:08
@jinohkang-theori jinohkang-theori marked this pull request as ready for review November 14, 2023 07:08
@Veykril
Copy link
Member

Veykril commented Dec 13, 2023

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Dec 13, 2023

📌 Commit 0beba7c has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 13, 2023

⌛ Testing commit 0beba7c with merge dd07f1f...

@bors
Copy link
Contributor

bors commented Dec 13, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing dd07f1f to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to named struct uses wrong locations for patterns in nested macros
4 participants