"implement missing members": const transformation #15035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ponyii
commented
Jun 12, 2023
crates/ide-db/src/path_transform.rs
Outdated
| @@ -11,7 +11,9 @@ use syntax::{ | |||
|
|
|||
| #[derive(Default)] | |||
| struct AstSubsts { | |||
| types: Vec<ast::TypeArg>, | |||
| // ast::TypeArgs stands in fact for both type and const params | |||
| // as consts declared elsewhere look just like type params. | |||
There was a problem hiding this comment.
not sure if I should report it
There was a problem hiding this comment.
This is expected, the parser cannot differentiate that, so for paths, type args might be const references but that cannot be known until the path is resolved semantically
ponyii
force-pushed
the
fix/implement-members-do-not-transform-const-params
branch
from
266e028 to
6b3659d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13363