Skip to content

Move empty diagnostics workaround back into the server #13133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Aug 28, 2022

This only touches on the diagnostics in one place instead of multiple as was previously done, since all published diagnostics will go through this code path anyways.

Closes #13130

@Veykril
Copy link
Member Author

Veykril commented Aug 28, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Aug 28, 2022

📌 Commit 9ad0a8c has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 28, 2022

⌛ Testing commit 9ad0a8c with merge e8e598f...

@bors
Copy link
Contributor

bors commented Aug 28, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e8e598f to master...

@bors bors merged commit e8e598f into rust-lang:master Aug 28, 2022
@Veykril Veykril deleted the diag-hack branch October 28, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excess placeholders in format string cause some errors to be silent
2 participants