Skip to content

Find original ast node before compute ref match #12830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

Find original ast node before compute ref match #12830

merged 1 commit into from
Jul 27, 2022

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Jul 20, 2022 •
edited
Loading

ref #12717

@0xPoe 0xPoe changed the title Find original as node before compute ref match Find original ast node before compute ref match Jul 20, 2022
@0xPoe 0xPoe force-pushed the rustin-patch-issue-12717-fix branch from 6fef889 to 465b174 Compare July 20, 2022 14:19
@0xPoe 0xPoe marked this pull request as draft July 20, 2022 14:45
@Veykril
Copy link
Member

Veykril commented Jul 27, 2022

The tests should succeed once #12886 is merged and this PR is rebased on top

@0xPoe 0xPoe force-pushed the rustin-patch-issue-12717-fix branch from 465b174 to d3dfa10 Compare July 27, 2022 11:10
@0xPoe
Copy link
Member Author

0xPoe commented Jul 27, 2022

The tests should succeed once #12886 is merged and this PR is rebased on top

Rebased. But still does not work. Did I miss using the API?

@Veykril
Copy link
Member

Veykril commented Jul 27, 2022

Hmm, will take another look at this later

@Veykril
Copy link
Member

Veykril commented Jul 27, 2022

Ah right, the path is from the fake file so we can't do that for the path here... hmm. Can you remove the ones that try to do this for paths, and only leave the receiver ones? Those should work, the path ones will be a bit more tricky to fix. will have to think about those

@0xPoe 0xPoe force-pushed the rustin-patch-issue-12717-fix branch from d3dfa10 to 349dfc7 Compare July 27, 2022 12:18
@0xPoe 0xPoe marked this pull request as ready for review July 27, 2022 12:18
@0xPoe
Copy link
Member Author

0xPoe commented Jul 27, 2022

Ah right, the path is from the fake file so we can't do that for the path here... hmm. Can you remove the ones that try to do this for paths, and only leave the receiver ones? Those should work, the path ones will be a bit more tricky to fix. will have to think about those

Done.
Thanks for your review! 💚 💙 💜 💛 ❤️

@Veykril
Copy link
Member

Veykril commented Jul 27, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jul 27, 2022

📌 Commit 349dfc7 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 27, 2022

⌛ Testing commit 349dfc7 with merge b4d652a...

@bors
Copy link
Contributor

bors commented Jul 27, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing b4d652a to master...

@bors bors merged commit b4d652a into rust-lang:master Jul 27, 2022
@lnicola lnicola mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xPoe @Veykril @bors