-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Lifetimes for structs and traits in inlay hints don't work in VSCode #17098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Right, we should not show error lifetimes for now as we have too many of them due to missing implementations |
@Veykril I'm not sure what you mean? Do you mean lifetime errors instead of error lifetimes? |
I'm saying we shouldn't render |
Adding a Settings option to disable showing lifetime specifiers in the inlay hints ( |
internal: Don't render unknown lifetimes when rendering generic args cc #17098
internal: Don't render unknown lifetimes when rendering generic args cc rust-lang/rust-analyzer#17098
internal: Don't render unknown lifetimes when rendering generic args cc rust-lang/rust-analyzer#17098
Hey @Veykril, I believe this issue can be closed now, as your PR has addressed it. |
rust-analyzer version: 0.3.1924-standalone (5dbe3fe 2024-04-14)
It also only occurs on this version (0.3.1924) and not previous ones like 0.3.1916
rustc version: rustc 1.77.2 (25ef9e3d8 2024-04-09)
editor or extension: VSCode
code snippet to reproduce:
The inlay hint for test is
Test<'{error}>
. You can also not turn them off. I don't want any lifetimes in inlay hints at all, they take up too much space, so an option to turn them off would be a win-win.The text was updated successfully, but these errors were encountered: