-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Make panic error shown on code optional. #14977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Duplicate of #14193 Note that server panics are always considered a bug, so you can also report that with a stack trace and optionally a repro. |
Sorry if I didn't specify. Apparently it's related to this new feature: 14749. It was introduced in the 0.3.1506 version, changelog number 180. |
Ah, sorry I misunderstood the issue. |
+1. Since this update I am often confused to see red text in my file names and assume I have a compilation error, and instead just find that it is an error from a very old test run that has since been fixed. Is there already a way to clear these errors? |
It would also be nice to indicate that it's rust-analyzers' error message. The source is shown as panic which is not very easy to understand. |
The utility of this feature is not worth the violation of what we usually take for granted about "problem" highlighting. Highlighting errors directly in the code serves some important roles, such as:
All three of these principles are violated by this feature.
When something I trust refuses to stop demanding my attention, it's hard to concentrate. I trust it and take it seriously because it usually means there is definitely something wrong with my code. I may learn to ignore error highlighting after I get desensitized to perpetual red herrings. That would be unfortunate. I can imagine a variant of this feature that would be acceptable. It should...
I don't think any feature like this should be in rust-analyzer at all unless it satisfies either A or both B and C. |
To re-enable this, use "rust-analyzer.runnables.problemMatcher": [ "$rustc", "$rust-panic" ], setting. closes: rust-lang#14977
feat: don't add panics to error jump list by default To re-enable this, use "rust-analyzer.runnables.problemMatcher": [ "$rustc", "$rust-panic" ], setting. closes: #14977
To re-enable this, use "rust-analyzer.runnables.problemMatcher": [ "$rustc", "$rust-panic" ], setting. closes: rust-lang#14977
Uh oh!
There was an error while loading. Please reload this page.
It would be interesting to have an option not to show runtime errors as an error in the code.
The text was updated successfully, but these errors were encountered: