Skip to content

A test for cast propagation #11571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ChayimFriedman2 opened this issue Feb 27, 2022 · 1 comment · Fixed by #14104 or #15271
Closed

A test for cast propagation #11571

ChayimFriedman2 opened this issue Feb 27, 2022 · 1 comment · Fixed by #14104 or #15271
Labels
A-ty type system / type inference / traits / method resolution C-bug Category: bug

Comments

@ChayimFriedman2
Copy link
Contributor

https://github.com/rust-analyzer/rust-analyzer/blob/b86baa709282a07e6678744a31b0d18e51a60504/crates/hir_ty/src/infer/expr.rs#L515

Here it is:

2022-02-27.10-06-55.mp4
@flodiebold flodiebold added A-ty type system / type inference / traits / method resolution C-bug Category: bug labels Feb 27, 2022
@Veykril Veykril mentioned this issue Feb 8, 2023
Merged
bors added a commit that referenced this issue Feb 8, 2023
@bors
Auto merge of #14104 - Veykril:castable-expect, r=Veykril
8c99124 
fix: Implement Expactation::Castable and add a test case for it

Fixes #11571
@bors bors closed this as completed in eaed19c Feb 8, 2023
@Veykril Veykril mentioned this issue Feb 10, 2023
Merged
bors added a commit that referenced this issue Feb 10, 2023
@bors
Auto merge of #14120 - Veykril:castable, r=Veykril
d9c020d 
internal: Revert castable expectation and simplify

Unfixes #11571, the PR for that introduced some regressions (tried fixing them but doing what rustc does there specifically does not help, probably because something else affects it as well there)
@lnicola
Copy link
Member

lnicola commented Feb 13, 2023

Unfixed in #14120.

@lnicola lnicola reopened this Feb 13, 2023
@lowr lowr mentioned this issue Jul 12, 2023
Merged
@bors bors closed this as completed in 037844c Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ty type system / type inference / traits / method resolution C-bug Category: bug
Projects
None yet
Milestone
No milestone
3 participants
@lnicola @flodiebold @ChayimFriedman2