This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Make crate blacklist user-configurable #1509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanewok
force-pushed
the
configurable-blacklist
branch
from
69c0757 to
4c18bc7
Compare
This in turns removes the old `use_crate_blacklist` setting. To not use the blacklist, one can specify `[]` as the config value.
Xanewok
force-pushed
the
configurable-blacklist
branch
from
4c18bc7 to
dc3cee9
Compare
bors
added a commit
that referenced
this pull request
Aug 11, 2019
Warn against deprecated config entries Addresses rust-lang/vscode-rust#643. Brings back removed option from #1509 but only not to trigger the unknown option warning.
bors
added a commit
that referenced
this pull request
Aug 11, 2019
Warn against deprecated config entries Addresses rust-lang/vscode-rust#643. Brings back removed option from #1509 but only not to trigger the unknown option warning.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1328
Closes #1303
Introduces a
crate_blacklistconfig that can be used to override the current default blacklist (equal to explicitly setting it tonull), to disable the blacklist set the value to an empty list[].Also removes
rls-blacklistcrate since it's not needed now as the default is stored in the RLS config module @nrc