Skip to content

add rust-toolchain file #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2018
Merged

add rust-toolchain file #175

merged 3 commits into from
Sep 17, 2018

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Sep 17, 2018

Closes #174 .

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Sep 17, 2018

I think that it's enough to have one rust-toolchain file in the examples/ directory since all examples are part of the same workspace. However, the current CI system copies the examples one by one to the target directory, "ignoring" this :/

GabrielMajeri
GabrielMajeri approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we should remember to update the README to inform people only nightly is supported.

Should we wait for CI to finish, or just merge now?

@gnzlbg gnzlbg merged commit bb2f88f into rust-lang:master Sep 17, 2018
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Sep 17, 2018

I've added a warning to the readme, and the rust-toolchain file of the root crate was missing (:D), let's see if this fixes dependabot issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielMajeri GabrielMajeri GabrielMajeri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnzlbg @GabrielMajeri