Skip to content

Update travis CI #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 30, 2017
Merged

Update travis CI #516

merged 3 commits into from
Dec 30, 2017

Conversation

Michael-F-Bryan
Copy link
Contributor

The last several releases haven't uploaded binaries. I've updated .travis.yml to use japaric/trust to configure travis, plus created a new Personal Access Token so releases should hopefully work again.

Testing on the beta channel was previously deactivated because there was a compiler issue (see #490 and #492). It should be working again so I've re-enabled beta testing.

Because I've added a bunch more targets the CI build times may be adversely affected... I'll see how it goes, but may end up removing a couple targets if it becomes a problem.

I'm not sure what we're going to do about Appveyor. It's been broken ever since we moved mdbook to the nursery, meaning we're not currently testing or generating release binaries for windows. The easiest way to deal with it would be to tell Appveyor that I can look after rust-lang-nursery/mdBook and I can deal with it from there, but @budziq mentioned that this may not be an overly straightforward process.

@Michael-F-Bryan
Copy link
Contributor Author

Michael-F-Bryan commented Dec 21, 2017 •
edited
Loading

As a datapoint on CI build times, the most recent master build ran for 10 minutes and 1 second (wall time). Note that this was done with a warm cache, whereas the first one or two builds generated by this PR will have to recompile everything.

I checked the build times for this PR after the cache has been warmed up and the times are pretty similar to before. As usual, the thing holding everything back is mac builds because they spend ages in the queue waiting to be run.

Just looking at the CI times for this PR I'm going to say using japaric/trust doesn't introduce any significant regressions.

@Michael-F-Bryan Michael-F-Bryan changed the title Start fixing CI Update travis CI Dec 30, 2017
@Michael-F-Bryan
Copy link
Contributor Author

I think I'll merge this as-is. It should fix the deploy issues with GitHub Releases and make sure we update GitHub Pages every time a PR is merged into master. So the travis side of CI should be alright.

The appveyor issue is still outstanding, but I think we'll need help from the infrastructure team to fix that.

I'll CC in the @rust-lang-nursery, hopefully someone there will be able to help us out.

@Michael-F-Bryan Michael-F-Bryan merged commit c721ba8 into rust-lang:master Dec 30, 2017
@Michael-F-Bryan Michael-F-Bryan restored the ci branch December 30, 2017 12:22
Michael-F-Bryan added a commit that referenced this pull request Dec 30, 2017
@Michael-F-Bryan
Forgot to install npm deps globally in #516
d4a5176
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Jan 3, 2018
Closed
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
@Michael-F-Bryan
Update travis CI (rust-lang#516)
f94a850 
* Use japaric/trust for travis configuration

* Moved the github pages logic (not running the script breaks the build)

* Removed the x86 linux musl build
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
@Michael-F-Bryan
Forgot to install npm deps globally in rust-lang#516
ac0b1c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Michael-F-Bryan