Skip to content

Define fdatasync on FreeBSD. It was introduced in FreeBSD 11.1. #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2018
Merged

Define fdatasync on FreeBSD. It was introduced in FreeBSD 11.1. #799

merged 1 commit into from
Mar 17, 2018

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Oct 11, 2017

No description provided.

@alexcrichton
Copy link
Member

Looks like CI may be failing?

@asomers
Copy link
Contributor Author

asomers commented Oct 11, 2017

It looks like your QEMU image is still based on FreeBSD 10. This PR will fail until you update that image.

@alexcrichton
Copy link
Member

Unfortunately this can't land until CI is green :(

@asomers
Copy link
Contributor Author

asomers commented Oct 11, 2017

Then what's the procedure to upgrade the QEMU image, and is there any reason to hold it back? The concerns around FreeBSD 12 compatibility don't apply here.

@alexcrichton
Copy link
Member

There should be some documentation in the ci folder about how it was originally created, and IIRC the result is just a QEMU image file which once you get working locally I can upload and the URLs here can get updated.

@valpackett
Copy link
Contributor

Just add it to skip_fn in libc-test/build.rs

This was referenced Mar 12, 2018
Closed
Merged
bors added a commit that referenced this pull request Mar 16, 2018
@bors
Auto merge of #950 - wezm:update-freebsd-ci-image, r=alexcrichton
12bdc41 
Update the FreeBSD CI image

As per #948 and #799 the FreeBSD CI qemu image needs to be updated to FreeBSD 11. I have done this and updated the README with the detailed steps taken. The new image is available for download at: http://bsd-ci.com/FreeBSD-11.1-RELEASE-amd64.qcow2.xz
@wezm
Copy link
Member

wezm commented Mar 16, 2018

@asomers the CI image has been updated to 11.1 so this might pass now.

@asomers
Copy link
Contributor Author

asomers commented Mar 16, 2018

Thanks @wezm ! You have generously rewarded my laziness.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 17, 2018

📌 Commit 549da8a has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 17, 2018

⌛ Testing commit 549da8a with merge 3e9ccfa...

bors added a commit that referenced this pull request Mar 17, 2018
@bors
Auto merge of #799 - asomers:fdatasync, r=alexcrichton
3e9ccfa 
Define fdatasync on FreeBSD.  It was introduced in FreeBSD 11.1.
@bors
Copy link
Contributor

bors commented Mar 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3e9ccfa to master...

@bors bors merged commit 549da8a into rust-lang:master Mar 17, 2018
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
@bors
Auto merge of rust-lang#799 - gnzlbg:has_test, r=gnzlbg
c1cc6e2 
Verify that all intrinsics have a run-time test

Add a check to stdsimd-verify to check that all intrinsics have a run-time test. This is not the case right now, but we should at least not add intrinsics without tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asomers @alexcrichton @valpackett @wezm @bors