-
Notifications
You must be signed in to change notification settings - Fork 653
Forget about the iterator type after constructing a JoinAll
.
#286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current type parameter situation is left over from before #255, when |
This seems reasonable to me, and it seems like we probably won't be storing the iterator in the Unfortunately this is a breaking change so this can't land until 0.2, but I don't mind keeping this around until that time. |
…items are 'static
Test added. |
Awesome, thanks! I've tagged this to ensure it makes it into 0.2 and we don't forget about it. |
@alexcrichton : It looks like |
Certainly! I'd recommend coordinating with @cramertj though! |
@stuhood Thanks for your help! Can you send a PR to 0.2 in the next hour or so? If not, I'd recommend waiting until later this afternoon once I've had a chance to reorg 0.2 into multiple crates, otherwise the rebase will be a pain. |
@cramertj : Should be able to, as this PR is already green. |
@stuhood Great! ty :) |
@cramertj, @alexcrichton : Opened #732. |
Landed in #732 |
Fixes #285.