Remote completion #1766
Open
Remote completion #1766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nemo157
reviewed
Jul 29, 2019
| /// | ||
| /// Panics if underlying future is still running in addition to the | ||
| /// ways it would panic when polling `RemoteHandle`. | ||
| pub fn recv(mut self) -> T { |
There was a problem hiding this comment.
Is there some name that might better indicate this panics if still running, unwrap_recv maybe? (I feel like there's a good chance users might assume this does a blocking receive).
There was a problem hiding this comment.
Hm. Or I could simply remove the method - try_recv should be good enough after all.
2 tasks
Also add recv and try_recv for RemoteHandle.
RemoteCompletionHandle erases the result type of the underlying future and can be passed to trait object methods to poll only for complection of the underlying future without retrieving the result.
stbuehler
force-pushed
the
remote-completion
branch
from
8e2bf19 to
d6e97bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow polling remote handles (and oneshot channels) for "completion", i.e. when the result is available (
poll_readyis used for "ready to send", so I usedpoll_complete- open to other suggestions), and to extract results without async context.Add
RemoteCompletionHandle<'_>to poll only for completion without extracting the result: can be passed to trait (object) methods as the underlying result type is erased (would be useful in rustasync/runtime#73).