Skip to content

Replace await! macro with await syntax #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2019
Merged

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 7, 2019

await syntax was implemented in rust-lang/rust#60586, and nightly-2019-05-09 has been released with the changes. Also, await! macro will be removed in the future.

Refs: migration tool

@buesima
Copy link

buesima commented May 8, 2019

Any hints how you replaced this? That would be great to know for projects already using await macros.

@Nemo157
Copy link
Member

Nemo157 commented May 8, 2019

There might be a rust-fixable suggestion available for a little while (see rust-lang/rust#60586 (comment))

@taiki-e
Copy link
Member Author

taiki-e commented May 8, 2019

@buesima https://github.com/taiki-e/replace-await

@taiki-e taiki-e marked this pull request as ready for review May 9, 2019 02:47
@taiki-e taiki-e changed the title [WIP] Replace await! macro with await syntax Replace await! macro with await syntax May 9, 2019
@taiki-e
Copy link
Member Author

taiki-e commented May 9, 2019

nightly-2019-05-09 released! 🎉

@cramertj cramertj merged commit b34d519 into rust-lang:master May 9, 2019
@taiki-e taiki-e deleted the await branch May 9, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants