Use a docker image for testing on CI #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
force-pushed
the
automate-all-the-things
branch
from
c484896 to
c6403d6
Compare
This gives a consistent environment and means we only have to update things in one place. It also makes sure that we're testing the commands that new contributors run.
jyn514
force-pushed
the
automate-all-the-things
branch
from
c6403d6 to
6e612b5
Compare
Nemo157
reviewed
Apr 25, 2020
Nemo157
reviewed
Apr 25, 2020
This will also make it easier to make changes in the future, since only one place has to be updated with the new default variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to add custom extensions to the database (e.g. for #721). It also makes sure that we're testing the same things that contributors are running. Finally, it makes it easier to test on different platforms (i.e. #621).