web: show the priority in the queue #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the tools docs.rs operators have to ensure a fair build queue to everyone is to manually deprioritize slow-to-build crates. Before this the priority wasn't exposed anywhere in the UI though, making the queue look weird when a bunch of crates were deprioritized. This changes the queue page to show the priority in the build queue if it's not '0'.
|
The screenshot and code looks great, but I'm not sure how to change the priority in the site so I can test locally. |
Open a psql shell (the password is Then run (remember the priority is inverted for reasons): UPDATE queue SET priority = 5 WHERE name = 'lazy_static'; |
|
Going to make a separate pull adding that to the README ;) Thanks! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the tools docs.rs operators have to ensure a fair build queue to everyone is to manually deprioritize slow-to-build crates. Before this the priority wasn't exposed anywhere in the UI though, making the queue look weird when a bunch of crates were deprioritized.
This changes the queue page to show the priority in the build queue if it's not '0'.
r? @jyn514