Skip to content

only build crates for default target unless asked #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

QuietMisdreavus
Copy link
Member

fixes #343

This PR makes it so that we don't automatically build crates for every target in our build container. See discussion in the linked issue for rationale.

I've also included an expansion of the documentation of the package metadata, since it wasn't very well explained before.

@nagisa
Copy link
Member

nagisa commented May 4, 2019

How to enable alternate targets should be made very visible. Not squirrelled somewhere in the annals of documentation, but as a link on the pop-out where the list of targets was originally. FWIW majority of my crates are cross-platform and expose platform-specific modules and this is the first time I hear about the docs.rs specific cargo.toml section.

no-default-features = true

# Target to test build on, used as the default landing page (default: "x86_64-unknown-linux-gnu")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this now looks very clear to me. Very helpful.

@dekellum
Copy link

dekellum commented May 6, 2019

Regarding the docs discovery problem, perhaps the Cargo Reference, Manifest Format could have a special note and link to https://docs.rs/about#metadata-for-custom-builds (ideally with that anchor id working) added?

@jyn514
Copy link
Member

jyn514 commented Nov 4, 2019

What is this waiting on? I would like to see this merged to reduce build times.

@pietroalbini
Copy link
Member

Well, for sure this PR will have to be rewritten from scratch, as chroot_builder (thankfully) doesn't exist anymore.

@jyn514
Copy link
Member

jyn514 commented Dec 21, 2019

Closing in favor of #532 (as mentioned above, this was obsoleted by Rustwide)

@jyn514 jyn514 closed this Dec 21, 2019
@QuietMisdreavus QuietMisdreavus deleted the no-more-targets branch January 10, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stop building crates on all targets
5 participants