start tracking build-start time for build-time reporting

migrations/20241021050229_builds-started-finished.down.sql

@@ -0,0 +1,2 @@
+ALTER TABLE builds DROP COLUMN build_started;
+ALTER TABLE builds RENAME COLUMN build_finished TO build_time;

migrations/20241021050229_builds-started-finished.up.sql

@@ -0,0 +1,5 @@
+ALTER TABLE builds
+    ADD COLUMN build_started TIMESTAMP WITH TIME ZONE;
+
+ALTER TABLE builds
+    RENAME COLUMN build_time TO build_finished;

src/db/add_package.rs

@@ -165,7 +165,7 @@ pub async fn update_build_status(conn: &mut sqlx::PgConnection, release_id: i32)
          FROM (
              SELECT
                r.id,
-               MAX(b.build_time) as last_build_time,
+               MAX(b.build_finished) as last_build_time,
                SUM(CASE WHEN b.build_status = 'success' THEN 1 ELSE 0 END) as success_count,
                SUM(CASE WHEN b.build_status = 'failure' THEN 1 ELSE 0 END) as failure_count
              FROM
@@ -257,7 +257,7 @@ pub(crate) async fn finish_build(
              build_server = $4,
              errors = $5,
              documentation_size = $6,
-             build_time = NOW()
+             build_finished = NOW()
          WHERE
             id = $7
          RETURNING rid",
@@ -348,8 +348,8 @@ pub(crate) async fn initialize_build(
     let hostname = hostname::get()?;
 
     let build_id = sqlx::query_scalar!(
-        "INSERT INTO builds(rid, build_status, build_server)
-         VALUES ($1, $2, $3)
+        "INSERT INTO builds(rid, build_status, build_server, build_started)
+         VALUES ($1, $2, $3, NOW())
          RETURNING id",
         release_id,
         BuildStatus::InProgress as BuildStatus,
@@ -628,6 +628,7 @@ mod test {
                 r#"SELECT
                 rustc_version,
                 docsrs_version,
+                build_started,
                 build_status as "build_status: BuildStatus",
                 errors
                 FROM builds
@@ -639,6 +640,7 @@ mod test {
 
             assert!(row.rustc_version.is_none());
             assert!(row.docsrs_version.is_none());
+            assert!(row.build_started.is_some());
             assert_eq!(row.build_status, BuildStatus::Failure);
             assert_eq!(row.errors, Some("error message".into()));
 

src/web/build_details.rs

@@ -72,7 +72,7 @@ pub(crate) async fn build_details_handler(
              builds.rustc_version,
              builds.docsrs_version,
              builds.build_status as "build_status: BuildStatus",
-             builds.build_time,
+             COALESCE(builds.build_finished, builds.build_started) as build_time,
              builds.output,
              builds.errors,
              releases.default_target