Skip to content

Add JSON output for badges #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add JSON output for badges #1256

wants to merge 3 commits into from

Conversation

coolshaurya
Copy link
Contributor

@coolshaurya coolshaurya commented Jan 21, 2021

Resolves #170.

The JSON matches the shields.io endpoint.

@coolshaurya coolshaurya marked this pull request as ready for review January 21, 2021 16:51
@coolshaurya
Copy link
Contributor Author

coolshaurya commented Jan 21, 2021

Hmm this could be a duplicate of #809 😄

@jyn514
Copy link
Member

jyn514 commented Jan 21, 2021

I have questions about the use case I'll ask on the issue. I don't think it makes sense to review the implementation until the design issues are settled.

@jyn514
Copy link
Member

jyn514 commented Jan 21, 2021

As per #170 (comment), I would prefer we fixed the latest bug rather than introducing a completely new API.

@jyn514 jyn514 closed this Jan 21, 2021
@coolshaurya coolshaurya deleted the batch-json branch January 22, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/crate/:crate/latest/builds.json strips the .json suffix
2 participants