Skip to content

Rename maintenance struct key from value to status #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Rename maintenance struct key from value to status #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/badge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ pub enum Badge {
branch: Option<String>,
service: Option<String>,
},
Maintenance { value: MaintenanceValue },
Maintenance { status: MaintenanceStatus },
}

#[derive(Debug, PartialEq, Clone, Copy, Deserialize, Serialize)]
#[serde(rename_all = "kebab-case")]
pub enum MaintenanceValue {
pub enum MaintenanceStatus {
ActivelyDeveloped,
PassivelyMaintained,
AsIs,
Expand Down
12 changes: 6 additions & 6 deletions src/tests/badge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use cargo_registry::app::App;
use cargo_registry::badge::{Badge, MaintenanceValue};
use cargo_registry::badge::{Badge, MaintenanceStatus};
use cargo_registry::krate::Crate;

use std::collections::HashMap;
Expand Down Expand Up @@ -108,10 +108,10 @@ fn set_up() -> (Arc<App>, Crate, BadgeRef) {
badge_attributes_circle_ci.insert(String::from("branch"), String::from("beta"));
badge_attributes_circle_ci.insert(String::from("repository"), String::from("rust-lang/rust"));

let maintenance = Badge::Maintenance { value: MaintenanceValue::LookingForMaintainer };
let maintenance = Badge::Maintenance { status: MaintenanceStatus::LookingForMaintainer };
let mut maintenance_attributes = HashMap::new();
maintenance_attributes.insert(
String::from("value"),
String::from("status"),
String::from("looking-for-maintainer"),
);

Expand Down Expand Up @@ -514,8 +514,8 @@ fn maintenance_required_keys() {

let mut badges = HashMap::new();

// Value is a required key
test_badges.maintenance_attributes.remove("value");
// Status is a required key
test_badges.maintenance_attributes.remove("status");
badges.insert(
String::from("maintenance"),
test_badges.maintenance_attributes,
Expand All @@ -537,7 +537,7 @@ fn maintenance_invalid_values() {

// "totes broken" is not a recognized value
test_badges.maintenance_attributes.insert(
String::from("value"),
String::from("status"),
String::from(
"totes broken",
),
Expand Down