Code

Ability to add/update user email#921

Code

Merged

bors-voyager[bot] merged 27 commits intorust-lang:masterrust-lang/crates.io:masterfrom

natboehm:add-user-emailnatboehm/crates.io:add-user-emailCopy head branch name to clipboard

Aug 3, 2017

Commits

Commits on Jul 28, 2017

• string can be input in email field which is sent to the backend, user email field then is updated in the database

  natboehm

  committed
  d89c3b0

  Copy full SHA for d89c3b0

• delete unsused variables

  natboehm

  committed
  0e663a4

  Copy full SHA for 0e663a4

• added rudimentary user email validation, has empty input error on the ember side, i think

  natboehm

  committed
  a39b380

  Copy full SHA for a39b380

• delete ember validation import, extract email input into component

  natboehm

  committed
  0e61301

  Copy full SHA for 0e61301

• save button disabled if email field empty, odd bug where input was sometimes undefined seems to be fixed

  natboehm

  committed
  ccc82e1

  Copy full SHA for ccc82e1

• added simple email validation

  natboehm

  committed
  671eeab

  Copy full SHA for 671eeab

• add error catch statement, fix javascript linting errors

  natboehm

  committed
  cb8efee

  Copy full SHA for cb8efee

• wrap input submit with form tag

  natboehm

  committed
  820d1d2

  Copy full SHA for 820d1d2

• add div to wrap email field

  natboehm

  committed
  94e1a25

  Copy full SHA for 94e1a25

• initial basic styling on email label

  natboehm

  committed
  7bdb157

  Copy full SHA for 7bdb157

• basic styling for viewing and editing email field

  natboehm

  committed
  45ce186

  Copy full SHA for 45ce186

• only displays 'please add email' message when email field is currently null

  natboehm

  committed
  c603bcb

  Copy full SHA for c603bcb

• display 'please add email' message only when email is not already added

  natboehm

  committed
  33addcf

  Copy full SHA for 33addcf

• Split EncodableUser into EncodablePrivateUser and EncodablePublicUser in order to try to keep user emails private, update tests to pass

  natboehm

  committed
  28dc5ed

  Copy full SHA for 28dc5ed

• fixes bug where GitHub login would update and overwrite current email stored in database

  Show description for 9fe427f
  natboehm

  committed
  9fe427f

  Copy full SHA for 9fe427f

• add test to put and get updates to user email, had to change GET /me to support test, for now

  natboehm

  committed
  593853e

  Copy full SHA for 593853e

• tests for empty email and checking that another user cannot change currently signed in user's email

  natboehm

  committed
  09786c8

  Copy full SHA for 09786c8

• add test to check for bug of GitHub login overwriting current email data updated by crates.io user

  natboehm

  committed
  ed1d2ee

  Copy full SHA for ed1d2ee

• add comments to tests, delete debug println

  natboehm

  committed
  8c4d959

  Copy full SHA for 8c4d959

• delete unused variable

  natboehm

  committed
  0dba390

  Copy full SHA for 0dba390

• cargo fmt

  natboehm

  committed
  b2b854c

  Copy full SHA for b2b854c

• delete function new_user_with_id

  natboehm

  committed
  96bb903

  Copy full SHA for 96bb903

Commits on Aug 2, 2017

• delete commented out code

  natboehm

  committed
  33abaa4

  Copy full SHA for 33abaa4

• reword please add email message

  natboehm

  committed
  0e618a3

  Copy full SHA for 0e618a3

• simplify isEmailNull function, edit error message

  natboehm

  committed
  0b90a74

  Copy full SHA for 0b90a74

• delete print statement

  natboehm

  committed
  48774f8

  Copy full SHA for 48774f8

• change regex to not match on newline characters - before users could potentially add their email, then garbage on a newline, which would still evaluate as valid

  natboehm

  committed
  45b6669

  Copy full SHA for 45b6669