Skip to content

Replace ember-set-body-class addon #4367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 26, 2021
Merged

Replace ember-set-body-class addon #4367

merged 2 commits into from
Dec 26, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 26, 2021

We can achieve the same thing with data attributes, with a bit less code :)

@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Dec 26, 2021
@Turbo87
Copy link
Member Author

Turbo87 commented Dec 26, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Dec 26, 2021

📌 Commit 1ecf28e has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Dec 26, 2021

⌛ Testing commit 1ecf28e with merge 6a37786...

@bors
Copy link
Contributor

bors commented Dec 26, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing 6a37786 to master...

@bors bors merged commit 6a37786 into rust-lang:master Dec 26, 2021
@bors bors mentioned this pull request Dec 26, 2021
Merged
1 task
@Turbo87 Turbo87 deleted the body-class branch December 26, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @bors