Skip to content

Add a big green download button. #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add a big green download button. #2641

wants to merge 1 commit into from

Conversation

hvenev
Copy link

@hvenev hvenev commented Jul 16, 2020

Fixes #2113, #1592, #1219, #65.

Note that the node ember proxy is a bit broken on Firefox. The browser sends Accept: text/html, and ember interprets it as a request to not proxy to crates.io. No such problem was observed with Chromium.

I've not tried to make this pretty either in terms of UI or in terms of code. It is just a demonstration of an approach to solve the issue.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jtgeibel (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Turbo87
Copy link
Member

Turbo87 commented Dec 6, 2020

thanks for the PR @hvenev!

#1592 (comment) explains our reasons for why we don't want to have a "Download" button on the crate pages though. I hope you understand. :)

@Turbo87 Turbo87 closed this Dec 6, 2020
@bronson
Copy link

bronson commented Apr 27, 2021

Maybe, instead of a big green button, you could add a link to that issue?

I just spent 20 minutes trying to figure out how to download crates. 5 minutes of that was clicking all over thinking "there's GOT to be a download button on here somewhere and I'm too blind to find it."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download button
5 participants