Fix cache control headers set for S3 uploads #2071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headers intended for crates and readme uploads were swapped.
jtgeibel
force-pushed
the
fix/swapped-cache-headers
branch
from
c10f743 to
5496bfd
Compare
|
Snap, how did we manage to get this wrong? I guess I was the one who let this slip in the review. It's a bit unfortunate the we uploaded readme files with an infinite lifetime, since they may theoretically linger around in some cache until the end of time. We should issue a CloudFront invalidation for the affected files to at least get them out of CloudFront. |
|
@bors r+ |
|
📌 Commit 5496bfd has been approved by |
bors
added a commit
that referenced
this pull request
Jan 5, 2020
Fix cache control headers set for S3 uploads The headers intended for crates and readme uploads were swapped. r? @smarnach
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headers intended for crates and readme uploads were swapped.
r? @smarnach