Skip to content

Update ember-cli-babel to v7.13.2 #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Update ember-cli-babel to v7.13.2 #1989

merged 1 commit into from
Dec 19, 2019

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 18, 2019

to unblock the ember-cli-htmlbars updates

@rust-highfive
Copy link

r? @carols10cents

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Dec 18, 2019

☔ The latest upstream changes (presumably #1986) made this pull request unmergeable. Please resolve the merge conflicts.

@locks
Copy link
Contributor

locks commented Dec 18, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Dec 18, 2019

📌 Commit 9c27318 has been approved by locks

@bors
Copy link
Contributor

bors commented Dec 18, 2019

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout babel-7 (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self babel-7 --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
Auto-merging package.json
Auto-merging package-lock.json
CONFLICT (content): Merge conflict in package-lock.json
Automatic merge failed; fix conflicts and then commit the result.

@bors
Copy link
Contributor

bors commented Dec 18, 2019

☔ The latest upstream changes (presumably #1970) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 18, 2019

@bors r=@locks

@bors
Copy link
Contributor

bors commented Dec 18, 2019

📌 Commit 992a39b has been approved by locks

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 19, 2019

@bors retry

🤔

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 19, 2019

@bors r=@locks

@bors
Copy link
Contributor

bors commented Dec 19, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Dec 19, 2019

📌 Commit 992a39b has been approved by locks

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 19, 2019

then why don't you merge it? 😅

@bors
Copy link
Contributor

bors commented Dec 19, 2019

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout babel-7 (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self babel-7 --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
Auto-merging package.json
Auto-merging package-lock.json
CONFLICT (content): Merge conflict in package-lock.json
Automatic merge failed; fix conflicts and then commit the result.

@bors
Copy link
Contributor

bors commented Dec 19, 2019

☔ The latest upstream changes (presumably #1988) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 19, 2019

thank you npm...

@bors r=@locks

@bors
Copy link
Contributor

bors commented Dec 19, 2019

📌 Commit 1e80d59 has been approved by locks

@bors
Copy link
Contributor

bors commented Dec 19, 2019

⌛ Testing commit 1e80d59 with merge b4846ed...

bors added a commit that referenced this pull request Dec 19, 2019
Update `ember-cli-babel` to v7.13.2

to unblock the `ember-cli-htmlbars` updates
@bors
Copy link
Contributor

bors commented Dec 19, 2019

☀️ Test successful - checks-travis
Approved by: locks
Pushing b4846ed to master...

@bors bors merged commit 1e80d59 into rust-lang:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants