Skip to content

Show crate last updated at on search results #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

jtescher
Copy link
Contributor

Adds the crate's last updated at time to search results on the right:

image

And with hover state to display exact date and time:

image

Happy to move it to a different location if preferrable, reasonable alternatives could be at the end of the quick links? or under the crate title?

Fixes #1597

@rust-highfive
Copy link

r? @jtgeibel

(rust_highfive has picked a reviewer for you, use r? to override)

@jtescher jtescher force-pushed the search-result-updated-at-time branch 2 times, most recently from ec4eb7f to 3f919de Compare October 18, 2019 21:09
@jtescher jtescher force-pushed the search-result-updated-at-time branch from 3f919de to ad8839c Compare October 18, 2019 22:09
@carols10cents
Copy link
Member

This looks great, thank you so much! Sorry for the delay on reviewing :)

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 8, 2019

📌 Commit ad8839c has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Testing commit ad8839c with merge f8a8855...

bors added a commit that referenced this pull request Nov 8, 2019
…s10cents

Show crate last updated at on search results

Adds the crate's last updated at time to search results on the right:

<img width="901" alt="image" src="https://user-images.githubusercontent.com/175237/67069778-0ae64500-f133-11e9-95fa-f9df665aa131.png">

And with hover state to display exact date and time:

<img width="937" alt="image" src="https://user-images.githubusercontent.com/175237/67069861-54cf2b00-f133-11e9-8a10-218a22aec92e.png">

Happy to move it to a different location if preferrable, reasonable alternatives could be at the end of the quick links? or under the crate title?

Fixes #1597
@bors
Copy link
Contributor

bors commented Nov 8, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing f8a8855 to master...

@bors bors merged commit ad8839c into rust-lang:master Nov 8, 2019
@jtescher jtescher deleted the search-result-updated-at-time branch November 13, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show last updated timestamp in search results
5 participants