Two-Space Linting #1817
Two-Space Linting #1817
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Can we merge #1715 before this one? Merging this change makes merging other open pull requests harder... |
|
It's true; @locks as you requested the change do you have thoughts on how to make this change timing-wise? |
|
I think it sounds good to wait for #1715 since it's a big PR. If there are other PRs affects, I'll personally update them to unblock them as necessary! |
|
Could we also get #1759 merged first? Not that that PR is particularly important, nor particularly big, but I believe that it is ready for merging, so it may save a bit of work to simply merge it. |
|
☔ The latest upstream changes (presumably #1759) made this pull request unmergeable. Please resolve the merge conflicts. |
|
You can go ahead and rebase now |
|
@sgrif thanks for coordinating—i should be able to do so tomorrow morning if that works ok |
|
@sgrif alright, this PR is all rebased and ready to go |
|
@bors: r+ |
|
📌 Commit a5c5db8 has been approved by |
Two-Space Linting Updates the JS and HBS linters to use the standard two-spaces instead of four, at @locks' request. This should make working with blueprints easier in the future. Other changes: - Adds the standard `lint:hbs` NPM script and runs it as part of CI. - Disable the `html-comments` lint rule, as there are HTML comments present.
|
☀️ Test successful - checks-travis |
Updates the JS and HBS linters to use the standard two-spaces instead of four, at @locks' request. This should make working with blueprints easier in the future.
Other changes:
lint:hbsNPM script and runs it as part of CI.html-commentslint rule, as there are HTML comments present.