Skip to content

Added check for yanked status when computing currentVersion #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2019
Merged

Added check for yanked status when computing currentVersion #1684

merged 1 commit into from
Mar 21, 2019

Conversation

sunng87
Copy link
Contributor

@sunng87 sunng87 commented Mar 21, 2019

Fixes #1683

sgrif
sgrif approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@sgrif sgrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'm going to hold off merging until later tonight or tomorrow since we're doing DB maintenance in a few hours and need to ship a few fixes before that

@sgrif
Copy link
Contributor

sgrif commented Mar 21, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 21, 2019

📌 Commit 4f75ce2 has been approved by sgrif

@bors
Copy link
Contributor

bors commented Mar 21, 2019

⌛ Testing commit 4f75ce2 with merge faf625e...

bors added a commit that referenced this pull request Mar 21, 2019
@bors
Auto merge of #1684 - sunng87:fix/version-get, r=sgrif
faf625e 
Added check for yanked status when computing currentVersion

Fixes #1683
@bors
Copy link
Contributor

bors commented Mar 21, 2019

☀️ Test successful - checks-travis
Approved by: sgrif
Pushing faf625e to master...

@bors bors merged commit 4f75ce2 into rust-lang:master Mar 21, 2019
@sunng87 sunng87 deleted the fix/version-get branch March 22, 2019 08:14
@sgrif sgrif mentioned this pull request Mar 29, 2019
Closed
@charmander charmander mentioned this pull request Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgrif sgrif sgrif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunng87 @sgrif @bors