Refactor how we convert from T: Error to dyn CargoError
#1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way we handled this before with a `Shim` struct breaks any later downcasting we may try to do, and can lead to errors slipping through in a hard to debug way. It's much easier if we just directly implement `CargoError` on those types (and lets us get rid of some trivial impls). This new impl conflicts with `impl<T: CargoError> CargoError for Box<T>`. It's fine to remove that impl. It means that `Box<ConcreteType>` no longer implements `CargoError`, but we wouldn't have boxed the error in the first place unless we needed `dyn CargoError`.
|
LGTM! bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Oct 13, 2018
1516: Refactor how we convert from `T: Error` to `dyn CargoError` r=jtgeibel a=sgrif The way we handled this before with a `Shim` struct breaks any later downcasting we may try to do, and can lead to errors slipping through in a hard to debug way. It's much easier if we just directly implement `CargoError` on those types (and lets us get rid of some trivial impls). This new impl conflicts with `impl<T: CargoError> CargoError for Box<T>`. It's fine to remove that impl. It means that `Box<ConcreteType>` no longer implements `CargoError`, but we wouldn't have boxed the error in the first place unless we needed `dyn CargoError`. Co-authored-by: Sean Griffin <[email protected]> Co-authored-by: Justin Geibel <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we handled this before with a
Shimstruct breaks any laterdowncasting we may try to do, and can lead to errors slipping through in
a hard to debug way. It's much easier if we just directly implement
CargoErroron those types (and lets us get rid of some trivial impls).This new impl conflicts with
impl<T: CargoError> CargoError for Box<T>. It's fine to remove that impl. It means thatBox<ConcreteType>no longer implementsCargoError, but we wouldn'thave boxed the error in the first place unless we needed
dyn CargoError.