Skip to content

Account for stable/prerelease when cheking for max version #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Account for stable/prerelease when cheking for max version #1212

wants to merge 2 commits into from

Conversation

behos
Copy link

@behos behos commented Dec 23, 2017

Max version will be calculated as the latest non-yanked,
non-prerelease version, followed by the latest non-yanked, prerelease
version followed by 0.0.0. This should be true for every crate object
returned by the API

This removes the custom front-end logic to fetch the max-version since this
is pre-calculated in the backend.

It also updates the search filter to exclude yanked versions

Fixes #1144

@behos
Copy link
Author

behos commented Dec 23, 2017

As discussed, this does not actually deal with the latest updates where the actual latest version needs to be shown

Max version will be calculated as the latest non-yanked,
non-prerelease version, followed by the latest non-yanked, prerelease
version followed by 0.0.0. This should be true for every crate object
returned by the API

This removes the custom front-end logic to fetch the max-version since this
is pre-calculated in the backend.

It also updates the search filter to exclude yanked versions

Fixes #1144
@carols10cents
Copy link
Member

I want to apologize for the delay in answering your questions, providing feedback, and generally moving this PR forward-- I haven't been a great maintainer lately.

Since this PR was opened, we have done quite a bit of refactoring that I think has improved the codebase, but unfortunately has made updating PRs a bit tricky. I feel bad about this too, and normally I would take on the work of resolving merge conflicts.

However, in order to try to get out from under the backlog of PRs that are outstanding, I've decided to aggressively close outdated PRs rather than update them. At this point it would probably take less time to reimplement the work rather than fix merge conflicts.

I appreciate the work you've put in here, and again I sincerely apologize for my lack of response. If you would like to work on this again in the future, I would be honored, but I also totally understand if you'd rather not.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants