Redirect /install to doc.crates.io #1035
Conversation
|
We're planning on deprecating doc.crates.io in the near-ish future; I think it's probably a better idea to just move the content over here, and redirect the other way. |
|
@steveklabnik I was thinking of updating the redirect later to the "Installation" chapter of the book, whenever the URL is stable. AFAIU, we want to keep that chapter in the Cargo Manual mdbook anyway, and it's easier to keep them in sync if both are in the What do you think? |
|
Uh, and the reason it's redirecting to the homepage of |
|
Ugh you know what, I also got confused with the policies vs install bit here, my bad. Sigh.
Yeah this seems good. Sorry for the noise! |
app/templates/install.hbs
Outdated
| Rust comes with Cargo by default, so the easiest way to get Cargo is to | ||
| <a href='http://www.rust-lang.org/install.html'>install Rust</a> via | ||
| the official binary installers. | ||
| Redirecting you to <code>https://crates.io/</code>… |
There was a problem hiding this comment.
Shouldn't this say "Redirecting you to http://doc.crates/io"? Since that's where the redirect is actually going...?
|
|
||
| export default Route.extend({ | ||
| redirect() { | ||
| window.location = 'http://doc.crates.io/'; |
There was a problem hiding this comment.
Should this be https? Or protocol-relative, so just //doc.crates.io?
There was a problem hiding this comment.
Unfortunately, https doesn't work on CNAME'd gh-pages, yet. Making this HTTPS or relative would make a false alarm like this:
behnam
force-pushed
the
install
branch
2 times, most recently
from
a1e664e to
d0084a1
Compare
|
|
||
| export default Route.extend({ | ||
| redirect() { | ||
| window.location = 'http://doc.crates.io/'; |
There was a problem hiding this comment.
Unfortunately, https doesn't work on CNAME'd gh-pages, yet. Making this HTTPS or relative would make a false alarm like this:
app/templates/install.hbs
Outdated
| Rust comes with Cargo by default, so the easiest way to get Cargo is to | ||
| <a href='http://www.rust-lang.org/install.html'>install Rust</a> via | ||
| the official binary installers. | ||
| Redirecting you to <code>https://crates.io/</code>… |
The content of the `install` page here is duplicate of `cargo`'s *Installation* page/section. Since it's not *registry*-specific feature, we better just redirect to the original source. The content of the page is already merged into <http://doc.crates.io/> and is live. Closes <rust-lang#1029>
|
Much better, thanks!! bors: r+ |
1035: Redirect /install to doc.crates.io r=carols10cents The content of the `install` page here is duplicate of `cargo`'s *Installation* page/section. Since it's not *registry*-specific feature, we better just redirect to the original source. The content of the page is already merged into <http://doc.crates.io/> and is live. See <#1029>
Build succeeded |
The content of the
installpage here is duplicate ofcargo'sInstallation page/section. Since it's not registry-specific feature,
we better just redirect to the original source.
The content of the page is already merged into http://doc.crates.io/
and is live.
See #1029